Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation/readme-section #113

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Jul 17, 2024

PR Overview

This PR will address the following Issue/Feature: Internal Ticket

This PR will result in the following new package version: N/A

This will not result in a new release at the moment. Instead we will merge this into main and the README update will be integrated into the next upcoming release. This edit was only required so the models descriptions may be viewed in the Fivetran UI for Quickstart.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • [n/a] dbt run –full-refresh && dbt test
  • [n/a] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • [n/a] docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • [n/a] Detailed validation steps have been provided below

❗ Special Updates for Ad Reporting ❗

To reduce integration testing time, not all models should be enabled in the run_models.sh vars. Update the variables after dbt run and dbt test to set:

  • [n/a] this PR's package to true
  • [n/a] Google Ads and Facebook Ads to true (if not already)
  • [n/a] All other packages to false

Detailed Validation

Please share any and all of your validation steps:

No validations were required for this update since this was only a README edit which will have no impact on users of the data model.

If you had to summarize this PR in an emoji, which would it be?

📑

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review July 17, 2024 15:43
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Fivetran-milanjovic Fivetran-milanjovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title Update README.md documentation/readme-section Jul 17, 2024
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion but otherwise lgtm!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit f6cf84c into main Jul 23, 2024
0 of 2 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the documentation/readme-section branch July 23, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants