update deps #60
Merged
update deps #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
changed the base branch from
main
to
MagicBot/add-union-schema
fivetran-joemarkiewicz
requested changes
Oct 4, 2023
packages.yml
Outdated
Comment on lines
2
to
7
| # - package: fivetran/google_ads_source | ||
| # version: [">=0.10.0", "<0.11.0"] | ||
|
|
||
| - git: https://github.com/fivetran/dbt_google_ads_source.git | ||
| revision: update_deps_versions | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to update before merge
There was a problem hiding this comment.
updated deps
|
Will need to do another docs regen after merge |
fivetran-joemarkiewicz
approved these changes
Oct 4, 2023
CHANGELOG.md
Outdated
| - Updates the [DECISIONLOG](DECISIONLOG.md) to clarify why there exist differences among aggregations across different grains. | ||
|
|
||
| - Updates the [DECISIONLOG](DECISIONLOG.md) to clarify why there exist differences among aggregations across different grains. ([PR #58](https://github.com/fivetran/dbt_google_ads/pull/58)) | ||
| - Removes the dependency on `dbt-expectations`. Upstream we specifically removed the `dbt_expectations.expect_column_values_to_not_match_regex_list` test. ([PR #60](https://github.com/fivetran/dbt_google_ads/pull/60)) |
There was a problem hiding this comment.
Let's be consistent with the other CHANGELOGS and have this be under the subheader for Dependency updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: n/a
This PR will result in the following new package version: v0.12.0
Linked to the upstream update fivetran/dbt_google_ads_source#47
Will require a full refresh to update for the logic coming from dbt-date and dbt-expectations
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Updates the dbt-date and dbt-expectations dependency version to the most current
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Run with a full refresh
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
💃