Fix: Rename folders to achieve correct materialization #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @NoToWarAlways thank you so much for opening this PR and catching this name change reflection in the There are a few minor updates I would like to make (upgrade the version number and add a CHANGELOG) before merging. Therefore, I will approve of this PR, but merge it with a staging branch to make the mentioned updates and then you can expect a new release of the package cut shortly after. Thanks! |
fivetran-joemarkiewicz
changed the base branch from
main
to
bugfix/notowarealways-materialization-change
fivetran-joemarkiewicz
approved these changes
Nov 2, 2021
fivetran-joemarkiewicz
merged commit cd0b745
into
fivetran:bugfix/notowarealways-materialization-change
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Simon Stepper, BI Lead, Capdesk
What change(s) does this PR introduce?
At some point in dev history, the folders for the google_ads and adwords models were renamed. This change wasn't taken into account in the dbt_project.yml. Hence, tmp models are materialized as tables in the warehouse. As these are just select * models, this uses unnecessary storage for Fivetran customers. This PR adjusts the folder names in project.yml to execute the wished materialization.
Does this PR introduce a breaking change?
We are only changing the materialization of the tmp models. This is done in the next dbt run and doesn't affect any downstream models.
Is this PR in response to a previously created Issue
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
😐
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.