Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp for changes to Google Ads connector #25

Merged
merged 12 commits into from
Feb 23, 2022
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dbt_google_ads_source v0.6.0
## 🚨 Breaking Changes 🚨
- The `account` source table has been renamed to be `account_history`. This has been reflected in this release. ([#25](https://github.com/fivetran/dbt_google_ads_source/pull/25))
- The `ad_final_url_history` model has been removed from the connector. The url fields are now references within the `final_urls` field within the `ad_history` table. ([#25](https://github.com/fivetran/dbt_google_ads_source/pull/25))
- Please be aware that the logic in the `stg_google_ads__ad_history` model for the Google Ads API will only pull through the first url in the `final_urls` list. This column should contain only one url. However, in the even that two are include a test will warn you that the other urls have been removed from the final model.

# dbt_google_ads_source v0.5.0
🎉 dbt v1.0.0 Compatibility 🎉
## 🚨 Breaking Changes 🚨
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Include in your `packages.yml`
```yaml
packages:
- package: fivetran/google_ads_source
version: [">=0.5.0", "<0.6.0"]
version: [">=0.6.0", "<0.7.0"]
```
## Configuration

Expand Down
5 changes: 2 additions & 3 deletions dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
name: 'google_ads_source'
version: '0.5.0'
version: '0.6.0'
config-version: 2
require-dbt-version: [">=1.0.0", "<2.0.0"]

vars:
google_ads__final_url_performance: "{{ source('adwords','final_url_performance') }}"
google_ads__click_performance: "{{ source('adwords','click_performance') }}"
google_ads__criteria_performance: "{{ source('adwords','criteria_performance') }}"
google_ads__ad_final_url_history: "{{ source('adwords','ad_final_url_history') }}"
google_ads__ad_stats: "{{ source('adwords','ad_stats') }}"
google_ads__ad_history: "{{ source('adwords','ad_history') }}"
google_ads__ad_group_history: "{{ source('adwords','ad_group_history') }}"
google_ads__campaign_history: "{{ source('adwords','campaign_history') }}"
google_ads__account: "{{ source('adwords','account') }}"
google_ads__account_history: "{{ source('adwords','account_history') }}"
api_source: adwords
google_ads__url_passthrough_metrics: []
google_ads__criteria_passthrough_metrics: []
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

32 changes: 16 additions & 16 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion docs/run_results.json

This file was deleted.

11 changes: 2 additions & 9 deletions integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
name: 'google_ads_source_integration_tests'
version: '0.4.1'
version: '0.6.0'
profile: 'integration_tests'
config-version: 2

vars:
google_ads__final_url_performance: "{{ ref('google_ads_final_url_performance_data') }}"
google_ads__click_performance: "{{ ref('google_ads_click_performance_data') }}"
google_ads__criteria_performance: "{{ ref('google_ads_criteria_performance_data') }}"
google_ads__ad_final_url_history: "{{ ref('google_ads_ad_final_url_history_data') }}"
google_ads__ad_stats: "{{ ref('google_ads_ad_stats_data') }}"
google_ads__ad_history: "{{ ref('google_ads_ad_history_data') }}"
google_ads__ad_group_history: "{{ ref('google_ads_ad_group_history_data') }}"
google_ads__campaign_history: "{{ ref('google_ads_campaign_history_data') }}"
google_ads__account: "{{ ref('google_ads_account_data') }}"
google_ads__account_history: "{{ ref('google_ads_account_history_data') }}"

seeds:
google_ads_source_integration_tests:
Expand Down Expand Up @@ -43,10 +42,6 @@ seeds:
id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
base_campaign_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
customer_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
google_ads_ad_final_url_history_data:
+column_types:
ad_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
ad_group_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
google_ads_ad_group_history_data:
+column_types:
id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
Expand All @@ -57,8 +52,6 @@ seeds:
+column_types:
id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
ad_group_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
base_adgroup_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
base_campaign_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"

dispatch:
- macro_namespace: dbt_utils
Expand Down
2 changes: 0 additions & 2 deletions integration_tests/seeds/google_ads_account_data.csv

This file was deleted.

2 changes: 2 additions & 0 deletions integration_tests/seeds/google_ads_account_history_data.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
id,updated_at,_fivetran_synced,auto_tagging_enabled,currency_code,descriptive_name,final_url_suffix,hidden,manager,manager_customer_id,optimization_score,pay_per_conversion_eligibility_failure_reasons,test_account,time_zone,tracking_url_template
2121450128,2022-02-01 2:20:51,2022-02-01 2:20:52,TRUE,USD,,FALSE,FALSE,,0.5,[],FALSE,America/Los_Angeles,,
Loading