Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/src databricks #32

Merged
merged 6 commits into from
Nov 16, 2022
Merged

Hotfix/src databricks #32

merged 6 commits into from
Nov 16, 2022

Conversation

fivetran-sheringuyen
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran Employee

What change(s) does this PR introduce?

Updates src.yml to include 'databricks' in target db section.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No
    This is a hotfix to unblock the release of Ad Reporting #69 - temporarily fixes failing integration tests for 🧱 Databricks 🧱

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-avinash fivetran-avinash self-requested a review November 16, 2022 01:32
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-sheringuyen Looks good! Mostly just clarifying questions, and mostly things I probably need to fix. 😅

.buildkite/scripts/run_models.sh Show resolved Hide resolved
README.md Show resolved Hide resolved
integration_tests/ci/sample.profiles.yml Show resolved Hide resolved
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore

Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Show resolved Hide resolved
@fivetran-sheringuyen fivetran-sheringuyen merged commit 619a8e6 into main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants