-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] dbt/quickbooks package breaking on build due to non-numerical sales_item_item_id #23
Comments
The logs are from a previous run, before I had a few other packages installed and before I updated dbt to 1.0.3. However, updating to 1.0.3 did not resolve the issue, so I included the more recent version info reflect my current configuration. |
Below is a list of what I believe to be affected models. (dbt-env) evan@evan-XPS-15-9500:~/code/dbt/my-transformations/my_transformations/dbt_packages$ grep -r 'cast(sales_item_item' | grep -v '"' |
@evancole-untitled I just made a few changes and see the error is resolved on my end. Would you be able to try the following branch of the Quickbooks package and let me know if you still see the error. packages:
- git: https://github.com/fivetran/dbt_quickbooks.git
revision: bugfix/evancole-untitled-casting
warn-unpinned: false |
After adjusting the I will be making a few last minute updates to the package and will be preparing it for review. Once it is approved during the review phase we will plan to merge this into the next release! |
@evancole-untitled this issue will now be resolved in the latest version of the dbt_quickbooks Feel free to open another issue if you encounter any errors, or open a FR if you would like to see more functionality from the package 😄 |
Is there an existing issue for this?
Describe the issue
I'm having some trouble getting the Quickbooks dbt package running for a client of ours.
The problem seems to be that there is an ItemRef field in Quickbooks that is typically a numerical ID, but which is sometimes set to
SHIPPING_ITEM_ID
in some quickbook configurations. Fivetran correctly pulls it over to our Redshift, but the Quickbooks dbt_quickbooks_source package attempts to cast this ID to integer, causing it to crash.Example: in dbt_packages/quickbooks_source/models/stg_quickbooks__credit_memo_line.sql the
sales_item_item_id
field seems to be populated by this ItemRef value, which makes all of my credit memo models fail.Relevant error log or model output
Expected behavior
the varchar field
sales_item_item_id
is imported as a varchar or text and the build completes successfullydbt Project configurations
name: 'my_transformations'
version: '1.0.3'
config-version: 2
profile: 'my_transformations'
model-paths: ["models"]
analysis-paths: ["analyses"]
test-paths: ["tests"]
seed-paths: ["seeds"]
macro-paths: ["macros"]
snapshot-paths: ["snapshots"]
target-path: "target" # directory which will store compiled SQL files
clean-targets: # directories to be removed by
dbt clean
models:
my_transformations:
staging:
+materialized: view
shopify:
+schema: staging
vars:
quickbooks vars
quickbooks_database: dev
quickbooks_schema: fivetran_quickbooks
Package versions
packages:
version: 0.4.0
What database are you using dbt with?
redshift
dbt Version
installed version: 1.0.3
latest version: 1.0.3
Up to date!
Plugins:
Additional Context
No response
Are you willing to open a PR to help address this issue?
The text was updated successfully, but these errors were encountered: