Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/evancole untitled casting #36

Merged
merged 8 commits into from
Apr 19, 2022

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Mar 25, 2022

Are you a current Fivetran customer?

Fivetran created PR that leverages the PR #23 and builds off PR #25 for quickbooks_source

What change(s) does this PR introduce?

This PR changes the ID casting from the previous release from type_int to type_string. This is needed as other users have found that some of these ID fields are in fact strings. To future proof this, we will cast all IDs as strings to ensure compatibility for the majority of users.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Since we are making such a large change to the package that will change the datatype of a number of fields that could be used to join on downstream models, this will result in a breaking change.

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature #23
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🧶

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the bug Something isn't working label Mar 25, 2022
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review March 25, 2022 15:42
Copy link
Contributor

@fivetran-sheringuyen fivetran-sheringuyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor versioning comments @fivetran-joemarkiewicz but ow lgtm!

README.md Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 8418102 into main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants