Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @file syntax to ds_tool #28

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Add @file syntax to ds_tool #28

merged 3 commits into from
Jun 13, 2024

Conversation

juberti
Copy link
Contributor

@juberti juberti commented Jun 13, 2024

Also:

  • makes the task name positional
  • defaults subset to None, as not every default is "default"
  • refactors the map func to be inside the task, making tasks more encapsulated

@juberti
Add @file syntax to ds_tool
4225172 
Also:
- makes the task name positional
- defaults subset to None, as not every default is "default"
- refactors the map func to be inside the task, making tasks more encapsulated
@juberti
x
236a2ef
@juberti juberti requested a review from farzadab June 13, 2024 05:04
farzadab
farzadab approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@farzadab farzadab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please make sure to update Justfile as well.

farzadab
farzadab reviewed Jun 13, 2024
View reviewed changes
ultravox/tools/ds_tool.py Outdated Show resolved Hide resolved
farzadab
farzadab reviewed Jun 13, 2024
View reviewed changes
ultravox/tools/ds_tool.py Outdated Show resolved Hide resolved
farzadab
farzadab reviewed Jun 13, 2024
View reviewed changes
ultravox/tools/ds_tool.py Outdated Show resolved Hide resolved
@juberti juberti merged commit 56104cf into main Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farzadab farzadab farzadab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juberti @farzadab