-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending ds_tool
for SODA conversational dataset
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farzadab
changed the title
Extending
[WIP] Extending Jun 15, 2024
ds_tool
for SODA conversational datasetds_tool
for SODA conversational dataset
juberti
reviewed
Jun 15, 2024
juberti
reviewed
Jun 15, 2024
farzadab
commented
Jun 19, 2024
farzadab
changed the title
[WIP] Extending
Extending Jun 19, 2024
ds_tool
for SODA conversational datasetds_tool
for SODA conversational dataset
juberti
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, just a few nits.
farzadab
commented
Jun 21, 2024
farzadab
commented
Jun 21, 2024
juberti
reviewed
Jun 21, 2024
juberti
approved these changes
Jun 21, 2024
juberti
reviewed
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
ds_tool
to have Jinja2 support which was used to create the SODA-audio dataset for training.It also adds a cache for TTS generation. The cache is necessary since TTS generation might fail from time to time, but a blind retry didn't seem like the best choice at this point (e.g. the first time we actually ran out of budget, so retrying would not have helped).