Notifications are never removed from dom

[Kepro]

After every item is disappear then we will see in dom react-empty comment, all dead notifications should be removed also internally

[fkhadra]

The dead notifications are removed. What you are seeing is the toast's containers which are removed after the n+1 iteration. This is done by design.

When you display a notification we check if for the given position a container exists. If yes, use it otherwise create one. In the meantime, we remove all unused container.

Go to the demo page, open your devtools and wait the end of the notification. You will see 6 containers, 1 for each position:

Then click on notify to display only one notification. All the containers will be removed except the one used to position the notification:

[Kepro]

I'm talking about

[fkhadra]

Can you provide a snippet to reproduce it?
Mine is getting empty:

[Kepro]

@fkhadra I'm using react 15.6.1 are you testing it on 16.0.0?

[fkhadra]

@Kepro yes I switched to react 16 and the same for the test. You think that it can cause the issue ?

[Kepro]

React 16 is handling this in a different way... in react 15.x if you return null then you will see react-empty as I showed in screenshot, but my point was that you still have all elements in your object, so after dismiss you don't remove it from there, this is also wasting memory in application, think if you have some system and it's running 24/7 without reloading and you never remove hidden notifications :)

I don't look at your code, maybe you have internal limit of max notifications and you clearing that queue

[fkhadra]

@Kepro you're right. I clean the "object" when the container is unmounted.
I got your point, I'll fix this. I guess it will be cleaner. Thanks !

[Kepro]

Thanks, sorry for no PR :) but don't have time now...

[fkhadra]

Don't worry :D. Finding a bug is a way to contribute

[dhirendrarathod2000]

@fkhadra i checked your demo
it removes from everything HTML dom but it keep container on React Dom