Drag.icon can also return None if clients don't provide icons to render #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drags provided by clients might not provide icons for rendering (e.g. google chrome), so trying to create Icons for ffi.NULL causes segfaults. E.g. see qtile/qtile#3894
m-col
added a commit
to m-col/qtile
that referenced
this pull request
Oct 28, 2022
Sometimes they don't provide icons when dragging (e.g. chrome when dragging tabs). Thus `wlr_drag.icon` can be `None`. Requires flacjacket/pywlroots#107 Fixes qtile#3894
This was referenced Oct 28, 2022
m-col
added a commit
to m-col/qtile
that referenced
this pull request
Oct 29, 2022
Sometimes they don't provide icons when dragging (e.g. chrome when dragging tabs). Thus `wlr_drag.icon` can be `None`. Requires flacjacket/pywlroots#107 Fixes qtile#3894
m-col
added a commit
to qtile/qtile
that referenced
this pull request
Oct 30, 2022
Sometimes they don't provide icons when dragging (e.g. chrome when dragging tabs). Thus `wlr_drag.icon` can be `None`. Requires flacjacket/pywlroots#107 Fixes #3894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drags provided by clients might not provide icons for rendering (e.g. google chrome), so trying to create Icons for ffi.NULL causes segfaults.
E.g. see qtile/qtile#3894