Use built-in version parsing from packaging #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianeboyd
force-pushed
the
use-packaging-version
branch
from
b0177a0 to
e85d6b3
Compare
|
Related to: #3289 (comment) You could also consider using |
Use version parsing from `packaging` to support all valid python version identifiers instead of the external `semver` library.
helpmefindaname
force-pushed
the
use-packaging-version
branch
from
50a9416 to
bc917ec
Compare
helpmefindaname
approved these changes
Aug 5, 2024
|
@adrianeboyd thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use version parsing from
packagingto support all valid python version identifiers instead of the externalsemverlibrary.