Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-80: Spanish Flair Embeddings #400

Closed
wants to merge 4 commits into from
Closed

GH-80: Spanish Flair Embeddings #400

wants to merge 4 commits into from

Conversation

alanakbik
Copy link
Collaborator

This PR adds pre-computed FlairEmbeddings for Spanish. Embeddings were computed over Wikipedia by @iamyihwa (see #80 )

To load Spanish FlairEmbeddings, simply do:

# default forward and backward embedding
embeddings_fw = FlairEmbeddings('spanish-forward')
embeddings_bw = FlairEmbeddings('spanish-backward')

# CPU-friendly forward and backward embedding
embeddings_fw_fast = FlairEmbeddings('spanish-forward-fast')
embeddings_bw_fast = FlairEmbeddings('spanish-backward-fast')

@@ -22,6 +23,20 @@
CACHE_ROOT = os.path.expanduser(os.path.join('~', '.flair'))


def load_big_file(f):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code belongs to PR #397. I guess you added it incidentally?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh oops yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll correct and do another PR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @alanakbik @tabergma !
Thanks a lot for adding it!
Glad to contribute a little bit after so much help from you guys! Thank you!

@alanakbik alanakbik closed this Jan 17, 2019
@alanakbik alanakbik deleted the GH-80-spanish-lm branch January 17, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants