Workaround #32 - fails parsing invalid utf8 dtrace output (macos only?) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intermittently, invalid utf-8 is found in cargo-flamegraph.stacks, which
causes parsing to blow up with the error:
> unable to collapse generated profile data: Custom { kind: InvalidData, error: StringError("stream did not contain valid UTF-8") }
This commit doesn't fix the underlying problem, but simply works around
it by lossily re-encoding to valid utf8.
Anecdotally it seems to be macos symbol names at the end of the line that
contain the invalid utf-8 - I don't know if this is due to some error in dtrace
or if somehow the symbols actually contain non utf-8 encodings.
Note I did try explicitly specifying utf8 output, by adding to the
dtrace command invocation:
command.arg("-x");
command.arg("encoding=utf8");
But I ran into the same error seemingly just as often.
|
Thanks for the workaround! I have also been bitten by this on OSX and I think this is an acceptable workaround for the time being. I've been bitten by a large number of annoying filesystem issues on OSX over time... I'll be cutting a new release in a few minutes that includes this change if bors is happy. bors r+ |
|
Build succeeded: |
|
Version 0.4 has been released which includes these changes. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermittently, invalid utf-8 is found in cargo-flamegraph.stacks, which causes parsing to blow up with the error:
This commit doesn't fix the underlying problem, but simply works around
it by lossily re-encoding to valid utf8.
Anecdotally it seems to be macos symbol names at the end of the line that
contain the invalid utf-8 - I don't know if this is due to some error in dtrace
or if somehow the symbols actually contain non utf-8 encodings.
Note I did try explicitly specifying utf8 output, by adding to the
dtrace command invocation:
But I ran into the same error seemingly just as often.
This is admittedly a hack, so I understand if you don't want to merge it, but it might be helpful for folks like me experiencing #32.
Anecdotally this commit seems to completely fix things for me. Without it I get the above error about 50% of the time — making it quite frustrating to use this otherwise very nice tool. 🙂
The caveat is that presumably the invalid symbol names will not be correctly labeled/classified, but in practice this hasn't bitten me yet, since it seems to be a relatively small number of affected lines.