Cleaner signal handling. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon termination of the tracing child, unregister the signal handler for SIGINT. This way, the user can still comfortably stop the generation of the flamegraph if necessary.
|
looks good! I'll cut a |
|
Great!
…On 2019-03-19, Tyler Neely wrote:
Merged #28 into master.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#28 (comment)
|
leod
pushed a commit
to leod/flamegraph
that referenced
this pull request
Jun 3, 2023
Cleaner signal handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #26, this implements a cleaner signal handling (essentially we remove the SIGINT handler as soon as the tracing child has exited in any way to allow the user to interrupt the remaining computations).