-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass in option --open to automatically open the resulting #45
Conversation
.svg file in the default program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and sorry for the delay in reviewing this! This looks like a reasonable addition to me. If you can rebase this onto the current master I'll take another look. Thanks!
Hello, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! Left a few more comments, then this should be good to go.
Great, thanks! |
…lamegraph-rs#45) * Allow to pass in option --open to automatically open the resulting .svg file in the default program * Modify according to the comments * Use only long argument * No need for a clone * Error implements Display trait
.svg file in the default program. Its similar operation to the
cargo doc --open