Don't spend time optimizing build deps, such as proc macros #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A build of flamegraph spends time optimizing various proc macros and
their dependencies, when they'll only run at build time and never at
runtime. Building them without optimizations substantially speeds up
the build, without affecting runtime performance at all.
Before:
Finished release [optimized] target(s) in 2m 35s
After:
Finished release [optimized] target(s) in 1m 31s
|
thank you! I'll cut a release with this in a few minutes |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A build of flamegraph spends time optimizing various proc macros and
their dependencies, when they'll only run at build time and never at
runtime. Building them without optimizations substantially speeds up
the build, without affecting runtime performance at all.
Before:
Finished release [optimized] target(s) in 2m 35s
After:
Finished release [optimized] target(s) in 1m 31s