Skip to content

Commit

Permalink
Merge pull request #1938 from thomasferrandiz/fix-windows-unimplemented
Browse files Browse the repository at this point in the history
remove unimplemented error in windows trafficmngr
  • Loading branch information
thomasferrandiz authored Apr 12, 2024
2 parents 00014d0 + 17a468d commit 03ab853
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions pkg/trafficmngr/iptables/iptables_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ type IPTables interface {
}

func (iptm IPTablesManager) Init(ctx context.Context, wg *sync.WaitGroup) error {
return trafficmngr.ErrUnimplemented
log.Warning(trafficmngr.ErrUnimplemented)
return nil
}

func (iptm *IPTablesManager) SetupAndEnsureForwardRules(ctx context.Context, flannelIPv4Network ip.IP4Net, flannelIPv6Network ip.IP6Net, resyncPeriod int) {
Expand All @@ -46,6 +47,6 @@ func (iptm *IPTablesManager) SetupAndEnsureMasqRules(ctx context.Context, flanne
flannelIPv6Net, prevIPv6Subnet, prevIPv6Network ip.IP6Net,
currentlease *lease.Lease,
resyncPeriod int) error {
log.Error(trafficmngr.ErrUnimplemented)
log.Warning(trafficmngr.ErrUnimplemented)
return nil
}
4 changes: 2 additions & 2 deletions pkg/trafficmngr/nftables/nftables_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type NFTablesManager struct {
}

func (nftm *NFTablesManager) Init(ctx context.Context, wg *sync.WaitGroup) error {
log.Error(trafficmngr.ErrUnimplemented)
log.Warning(trafficmngr.ErrUnimplemented)
return nil
}

Expand All @@ -41,6 +41,6 @@ func (nftm *NFTablesManager) SetupAndEnsureMasqRules(ctx context.Context, flanne
flannelIPv6Net, prevIPv6Subnet, prevIPv6Network ip.IP6Net,
currentlease *lease.Lease,
resyncPeriod int) error {
log.Error(trafficmngr.ErrUnimplemented)
log.Warning(trafficmngr.ErrUnimplemented)
return nil
}

0 comments on commit 03ab853

Please sign in to comment.