Enhance the part of how to build flannel.exe #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it works on ubuntu, Fedora/Redhat needs to enhance too.
This was referenced Jan 26, 2019
|
/lgtm |
ksubrmnn
reviewed
Jan 28, 2019
| @@ -22,10 +22,13 @@ Then you should be able to set the ARCH as above | |||
| ## Building manually | |||
|
|
|||
| 1. Make sure you have required dependencies installed on your machine. | |||
| * On Ubuntu, run `sudo apt-get install linux-libc-dev golang gcc`. | |||
| * On Ubuntu, run `sudo apt-get install linux-libc-dev golang gcc`. | |||
| If the golang version installed is not 1.7 or higher. Download the newest golang and install manully. | |||
There was a problem hiding this comment.
Yeah. You can just edit it or another PR from me?
| * On Ubuntu, run `sudo apt-get install linux-libc-dev golang gcc`. | ||
| * On Ubuntu, run `sudo apt-get install linux-libc-dev golang gcc`. | ||
| If the golang version installed is not 1.7 or higher. Download the newest golang and install manully. | ||
| To build the flannel.exe on windows, mingw-w64 is also needed. Run command `sudo apt-get install mingw-w64` |
There was a problem hiding this comment.
Do you mean flanneld.exe?
There was a problem hiding this comment.
Yeah, it's a typo error.
Meanwhile, for Fedora/Redhat, I think the mingw-w64 is also needed, but I only test on Ubuntu. Maybe someone who is in charge of the document can improve this section too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it works on ubuntu, the part of Fedora/Redhat needs to enhance too.
Description
Todos
Release Note