Add note about putting a flanneld binary in /opt/bin #1563
Conversation
radiosilence
changed the title
|
Not sure how a doc change could cause tests to fail :) |
|
ya it's not you, the e2e tests are broke |
|
Hello! Why do we need the manual installation of the raw It is very confusing addition. We've recently deployed a number of K8s clusters using Flannel CNI plugin by Flannel Pods are starting automatically after node reboot, as expected. |
|
Doesn't make any sense ... why was this merged @luthermonson ? |
|
Just gonna +1 this question, what's up with this requirement, @luthermonson ? |
|
I'm also confused by this change. Shouldn't it get reverted? I guess, if necessary, it could be documented somewhere else in the README for alternative setups but it really doesn't seem to belong in front of
[michael@groot ~]$ /opt/bin/flanneld --version
-bash: /opt/bin/flanneld: No such file or directory
[michael@groot ~]$ podman run -it --entrypoint /bin/sh docker.io/rancher/mirrored-flannelcni-flannel:v0.19.0
/ # /opt/bin/flanneld --version
v0.19.0So the advice of installing |
|
Is this one of those things where a University program is submitting bad changes to see if people notice, maybe? |
As several people already pointed out on pull request flannel-io#1563, the instructions added in there are not necessary. In fact, blindly following these instructions actually caused some trouble for me since I ran into issue flannel-io#1418 and started debugging that problem before realizing that I don't actually need the binary in `/opt/bin`. The pull request also does not provide any reasoning for why this could be necessary. Given that, and given that many people install Flannel without doing this, it's probably fair to remove this again to prevent more people running into the issue I had. This reverts commit a93a407.
As several people already pointed out on pull request flannel-io#1563, the instructions added in there are not necessary. In fact, blindly following these instructions actually caused some trouble for me since I ran into issue flannel-io#1418 and started debugging that problem before realizing that I don't actually need the binary in `/opt/bin`. The pull request also does not provide any reasoning for why this could be necessary. Given that, and given that many people install Flannel without doing this, it's probably fair to remove this again to prevent more people running into the issue I had. This reverts commit a93a407.
Description
It took me ages to figure this out