Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify trafficmanager interface #1866

Conversation

thomasferrandiz
Copy link
Contributor

@thomasferrandiz thomasferrandiz commented Feb 12, 2024

Description

There are now only two methods:

  • SetupAndEnsureForwardRules
  • SetupAndEnsureMasqRules
    This will help hide the implementation details that are specific to
    iptables and nftables.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@thomasferrandiz thomasferrandiz force-pushed the simplify-trafficmanager-interface branch from 5582b2b to e971a98 Compare February 12, 2024 09:06
@thomasferrandiz thomasferrandiz marked this pull request as ready for review February 12, 2024 09:55
There are now only two methods:
- SetupAndEnsureForwardRules
- SetupAndEnsureMasqRules
This will help hide the implementation details that are specific to
iptables and nftables.
@thomasferrandiz thomasferrandiz force-pushed the simplify-trafficmanager-interface branch from e971a98 to b76def1 Compare February 12, 2024 10:29
@thomasferrandiz thomasferrandiz merged commit f5b88d9 into flannel-io:master Feb 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants