Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default chart behaviour #1925

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

manuelbuil
Copy link
Collaborator

Description

This PR restores the default chart behavior which was tolerating all kind of taints. It even expands it to "NoSchedule" too

Todos

  • Tests
  • Documentation
  • Release note

Release Note

The flannel chart now tolerates all kind of taints

Signed-off-by: Manuel Buil <mbuil@suse.com>
Copy link

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯

@rbrtbnfgl
Copy link
Contributor

I don't know if we can create a release only for the chart. Right now a new chart is generated when a new flannel release is created

@manuelbuil manuelbuil merged commit 2466ff9 into flannel-io:master Apr 8, 2024
8 checks passed
@manuelbuil manuelbuil deleted the restoreDefault branch April 8, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants