Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli args for etcd basic auth #409

Merged
merged 1 commit into from
May 24, 2016
Merged

Conversation

shanegibbs
Copy link
Contributor

Adds support for --etcd-username and --etcd-password args.

@shanegibbs shanegibbs mentioned this pull request Feb 23, 2016
@philips
Copy link
Contributor

philips commented Feb 23, 2016

this seems fine

@dcbw
Copy link
Contributor

dcbw commented Mar 8, 2016

Seems fine to me too

@cvle
Copy link

cvle commented Mar 10, 2016

+1 Hope this will be merged soon.

@shanegibbs
Copy link
Contributor Author

@philips, what would the process to get this merged be? Anything I can help with?

@shanegibbs
Copy link
Contributor Author

Looks like the etcd client v3 won't be using basic auth

@tomdee
Copy link
Contributor

tomdee commented May 24, 2016

Small, simple and potentially useful change. We'll cross the etcd v3 bridge when we get to it. Merging.

@tomdee tomdee merged commit 186b85a into flannel-io:master May 24, 2016
@tomdee tomdee mentioned this pull request Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants