Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: remove eyakubovich; add tomdee, philips, steveej #437

Merged
merged 1 commit into from
May 18, 2016

Conversation

tomdee
Copy link
Contributor

@tomdee tomdee commented May 17, 2016

No description provided.

@tomdee tomdee force-pushed the update-maintainers branch from f2df3ef to e2d5532 Compare May 17, 2016 18:11
@steveej
Copy link
Contributor

steveej commented May 17, 2016

This is not critical here but we usually conform to a specific commit message format, in short: subsystem: the change.

For example:
MAINTAINERS: remove eyakubovich; add tomdee, philips, steveej

@steveej steveej changed the title Update maintainers list MAINTAINERS: remove eyakubovich; add tomdee, philips, steveej May 17, 2016
@@ -1 +1,3 @@
Eugene Yakubovich <eugene.yakubovich@coreos.com> (@eyakubovich)
Tom Denham <tom@tigera.io> (@tomdee)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the ordering here, favourite->leastfavourite? ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetical by second letter of the first name 😄

@tomdee tomdee force-pushed the update-maintainers branch from e2d5532 to 9ecd8fd Compare May 17, 2016 19:42
@tomdee tomdee force-pushed the update-maintainers branch from 9ecd8fd to 804520a Compare May 17, 2016 19:44
@steveej steveej merged commit 5d0f023 into flannel-io:master May 18, 2016
@tomdee tomdee deleted the update-maintainers branch January 23, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants