Remove the experimental support for multiple networks. #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdee
force-pushed
the
remove-multiple-networks
branch
2 times, most recently
from
9a98b61 to
47bfe96
Compare
tomdee
force-pushed
the
remove-multiple-networks
branch
2 times, most recently
from
ed59d3e to
e00c9cd
Compare
tomdee
force-pushed
the
remove-multiple-networks
branch
2 times, most recently
from
321a78f to
915f291
Compare
It is not widely used and it makes the code complicated.
tomdee
force-pushed
the
remove-multiple-networks
branch
from
915f291 to
01afb49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not widely used and it makes the code complicated.
There are a few other fixes in this PR (which would be split out if needed)
I added an automated test using multiple networks (with multiple daemons)
and I added documentation describing how to use multiple networks (with multiple daemons)