Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RevokeLease from manager interface #776

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Remove RevokeLease from manager interface #776

merged 1 commit into from
Jul 21, 2017
+0 −32

Conversation

tomdee
Copy link
Contributor

@tomdee tomdee commented Jul 14, 2017

No description provided.

@tomdee tomdee requested a review from gunjan5 July 14, 2017 22:11
@gunjan5
Copy link
Contributor

gunjan5 commented Jul 17, 2017 •
edited
Loading

@tomdee looks mostly good code wise, my only concern is what happens to the subnet entry in etcd if someone upgrades flannel?

gunjan5
gunjan5 previously approved these changes Jul 21, 2017
View reviewed changes
@gunjan5 gunjan5 dismissed their stale review July 21, 2017 05:43

forgot i had a comment on this

@tomdee
Copy link
Contributor Author

tomdee commented Jul 21, 2017

@gunjan5 I don't follow. How does this code change affect the subnet entry in etcd?

@tomdee tomdee assigned gunjan5 and unassigned tomdee Jul 21, 2017
@tomdee
Copy link
Contributor Author

tomdee commented Jul 21, 2017

Discussed offline and @gunjan5 says SGTM.

@tomdee tomdee merged commit 3034518 into flannel-io:master Jul 21, 2017
@tomdee tomdee mentioned this pull request Aug 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunjan5 gunjan5 gunjan5 left review comments

Assignees

@gunjan5 gunjan5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomdee @gunjan5