subnet/*: Remove unused reservations code #809
Merged
+0
−262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concept of a reservation was added a long time ago but never exposed to users. This commit removes that code. Reservations were part of the subnet manager interface but only implemented by the etcd backend. The Kube backend had stub code to implement the interface but threw errors when called.
gunjan5
approved these changes
Sep 15, 2017
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept of a reservation was added a long time ago but never exposed
to users. This commit removes that code.
Reservations were part of the subnet manager interface but only
implemented by the etcd backend. The Kube backend had stub code to
implement the interface but threw errors when called.