Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all the available interfaces when none were found #940

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Log all the available interfaces when none were found #940

merged 1 commit into from
Feb 2, 2018

Conversation

dmathieu
Copy link
Contributor

@dmathieu dmathieu commented Feb 1, 2018

Description

I was trying to use the --iface-regex and my interface wasn't detected (for a dumb reason. I was adding quotation marks to the argument, and those were added to the string).
At first, I thought this was because my interfaces weren't properly detected by flannel though.

This improves the no detected interfaces error message to show all the available interfaces, name and IP address so it's clearer what the issue could be.

Todos

  • Tests
  • Documentation
  • Release note

I haven't written tests here because main.go doesn't have any, and setting up unit testing seems outside the purpose of this small PR.

Release Note

None required

@tomdee
Copy link
Contributor

tomdee commented Feb 2, 2018

Looks good, thanks.

@tomdee tomdee merged commit ce1f224 into flannel-io:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants