Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: "Flare" directory should be created if it does not exist #1870

Closed
dorkster opened this issue Oct 6, 2023 · 4 comments
Closed

Android: "Flare" directory should be created if it does not exist #1870

dorkster opened this issue Oct 6, 2023 · 4 comments

Comments

@dorkster
Copy link
Collaborator

dorkster commented Oct 6, 2023

With the way modern Android works, users likely don't even have permission to drop the game files into the app's data directory.

The game already looks for a "Flare" directory on internal and external storage. We just need to ensure it's created.

@dorkster dorkster added this to the 1.15 milestone Oct 6, 2023
@dorkster dorkster added this to v1.15 Oct 11, 2023
@dorkster dorkster moved this to Todo in v1.15 Oct 11, 2023
@BRBsoup
Copy link

BRBsoup commented Nov 5, 2023

So the directions for Android install should really say to add game data to "internal storage/Flare/mods" or "/storage/emulated/0/Flare/mods"

@dorkster
Copy link
Collaborator Author

dorkster commented Nov 5, 2023

So the directions for Android install should really say to add game data to "internal storage/Flare/mods" or "/storage/emulated/0/Flare/mods"

Yes. The game looks for the "Flare" directory first, so the game will suggest it for installing data. Provided it exists.

@BRBsoup
Copy link

BRBsoup commented Nov 5, 2023

So the directions for Android install should really say to add game data to "internal storage/Flare/mods" or "/storage/emulated/0/Flare/mods"

Yes. The game looks for the "Flare" directory first, so the game will suggest it for installing data. Provided it exists.
It would be great to just clarify that at least here:

https://github.com/flareteam/flare-engine/wiki/Android-Port

I was wondering why the install directions said that 2 paths would be suggested and I only saw one. Since as of now those directions need to be read and followed anyway, its as important as the suggested directory path which the game shows. Given that with at least Android 13 the data folder can't easily be written to, after much trying to get the game installed, it was only after finding this issue ticket, plus the "logging" sections of the directions, that I went ahead and made the directory and was able to get it working! Thanks so much for making such a good quality game available cross-platform and especially for Android! I realize that it can be a pain for Android app porting/development, especially with Google making changes and/or increasingly locking down the system in such annoying ways...

@TechnologyClassroom
Copy link

I think it should either come with the default game or say something like, "Default game not found. Would you like to install? Install or Exit"

@github-project-automation github-project-automation bot moved this from Todo to Done in v1.15 Nov 12, 2023
dorkster added a commit to dorkster/flare-engine that referenced this issue Nov 12, 2023
Closes flareteam#1870

Also added a dialog message that can direct the player to the wiki page
that has instructions for installing the game data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants