Skip to content

Commit

Permalink
Improve how displayNameOptions are assembled, don't include unused nu…
Browse files Browse the repository at this point in the history
…merical index
  • Loading branch information
askvortsov1 committed May 19, 2020
1 parent 9e3ec30 commit fc5f294
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions js/src/admin/components/BasicsPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ export default class BasicsPage extends Page {

this.displayNameOptions = {};
const displayNameDrivers = app.data.displayNameDrivers;
for (const i in displayNameDrivers) {
this.displayNameOptions[displayNameDrivers[i]] = `${displayNameDrivers[i]} (${i})`;
}
displayNameDrivers.forEach(function (identifier) {
this.displayNameOptions[identifier] = identifier;
}, this);

if (!this.values.display_name_driver() && displayNameDrivers.includes('username')) this.values.display_name_driver('username');

Expand Down

0 comments on commit fc5f294

Please sign in to comment.