Fix header contents moving when opening modal #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
approved these changes
May 23, 2020
askvortsov1
added a commit
that referenced
this pull request
Oct 7, 2020
This reverts commit 4b68645.
Merged
askvortsov1
added a commit
that referenced
this pull request
Oct 9, 2020
* Revert "Fix header contents moving when opening modal (#2131)" * Fix header contents moving when modal opened/closed. Conditionally apply the navbar-fixed-top class only when needed, so that we can take advantage of it without always having the navbar in position:fixed, as was done in the previous solution. That resulted in a clash with custom headers. * Show header on refresh of scrolled page Due to some magic in Mithril 0.1's context:retain flag, some DOM elements were cached across page reloads. Since that has been eliminated, if we refresh the page and we are scrolled down, the "affix" class which makes the header fixed (and as a result, visible) isn't applied until the first scroll. We fix this by running ScrollListener.update() immediately to set initial navbar state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following minor bug:
Header contents move on desktop when modal is opened.
Steps:
-> Header contents move back and forth when opening and closing the modal. (Chrome)
Reason: Scrollbar is disabled when modal is open. A padding-right is applied to the body to account for that. When header position is fixed, it does not apply the padding.
Changes proposed in this pull request:
Bootstrap modal has a builtin class navbar-fixed-top that fixes that issue.
Reviewers should focus on:
Changed the header css class to position:fixed for @tablet-up.
Confirmed