TypeScript Initial Conversion #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you expand on that? I don't see any potential for conflicts right now... |
|
I'd also be in favor of starting to merge TS stuff not, the two don't really conflict |
|
@franzliedke This PR is basically whatever TS is converted before state PRs are merged. Not necessarily because of conflicts, but to only have one PR for the initial batch that isn't very complicated and goes file-by-file. |
|
This batch already looks great, and very manageable in size. 😃 |
franzliedke
reviewed
Jun 30, 2020
franzliedke
suggested changes
Jul 3, 2020
dsevillamartin
force-pushed
the
ds/typescript-conversion
branch
from
accbfa5
to
fe01696
Compare
This file isn't used anywhere. We should be calling it at some point. It has existed for 5 years. Renamed function because it makes more sense for name to match file name (not that it matters when building)
franzliedke
force-pushed
the
ds/typescript-conversion
branch
from
fe01696
to
455327c
Compare
franzliedke
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2206.
Currently PRs into
ds/typescriptbranch so TypeScript infrastructure (#2206) is available for building.Merge after state PRs are done.