Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Extension Order Resolution #2317

Closed
wants to merge 18 commits into from
Closed

WIP: Extension Order Resolution #2317

wants to merge 18 commits into from

Commits on Sep 24, 2020

  1. Add relevant exceptions for enabling/disabling

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    4738e5e View commit details
    Browse the repository at this point in the history

  2. Add helper method for getting flarum extension dependencies

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    ccd9993 View commit details
    Browse the repository at this point in the history

  3. Add extension dependency resolver (Kahn's algorithm), plus unit tests

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    6ec0f72 View commit details
    Browse the repository at this point in the history

  4. Enable extensions in proper order

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    71b3f91 View commit details
    Browse the repository at this point in the history

  5. Fix no default when getting extension dependencies

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    de8ae66 View commit details
    Browse the repository at this point in the history

  6. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @luceos @askvortsov1
    luceos authored and askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    ebd7984 View commit details
    Browse the repository at this point in the history

  7. Use require instead of dedicated field to get extension dependencies

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    7bd20b7 View commit details
    Browse the repository at this point in the history

  8. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @luceos @askvortsov1
    luceos authored and askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    78f4f9d View commit details
    Browse the repository at this point in the history

  9. Fix fake extension to not fail tests and be compliant

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    b9fedeb View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary import

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    f2d86e3 View commit details
    Browse the repository at this point in the history

  11. Fix constructor, remove KnownError since we'll need a custom handler

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    c5dcd5d View commit details
    Browse the repository at this point in the history

  12. Add custom handlers for dependency exceptions

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    713a532 View commit details
    Browse the repository at this point in the history

  13. Standardize return format

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    cc8393b View commit details
    Browse the repository at this point in the history

  14. Add frontend error handler for admin dashboard

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    fa35f04 View commit details
    Browse the repository at this point in the history

  15. Fix dependentExtensions saving the wrong thing

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    b166f94 View commit details
    Browse the repository at this point in the history

  16. Update src/Extension/Exception/DependentExtensionsException.php 

    Co-authored-by: Daniël Klabbers <luceos@users.noreply.github.com>
    @askvortsov1 @luceos
    askvortsov1 and luceos committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    2e7b1a1 View commit details
    Browse the repository at this point in the history

  17. Update for new alerts signature

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    905de50 View commit details
    Browse the repository at this point in the history

  18. Add more tests for dependency resolution

    @askvortsov1
    askvortsov1 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    024487e View commit details
    Browse the repository at this point in the history