-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Namespace #2645
Query Namespace #2645
Conversation
I agree, what about having it and
Yea, We'd be overdoing it imo. |
4ccbeda
to
a24981c
Compare
**Part of flarum/issue-archive#286 **
Changes proposed in this pull request:
Move search results, search criteria, and ApplySearchParametersTrait to Query namespace.
They still extend (empty) search equivalents as a BC layer for extensions that expect those types.
Reviewers should focus on:
A few changes I'm considering, but am unsure about:
query
method, and having both searchers and filterers implement it instead offilter
andsearch
methods. Leaning against this though because it isn't really necessary, and I don't see the benefits.An actual extender for search drivers will have to wait until next release (or later), although that shouldn't be too difficult. Not a priority right now though.