[1.x] [extensibility] Export all missing modules in compat

[DavideIadeluca]

Fixes #4006 (comment)

Changes proposed in this pull request:

• Export all missing modules with the Compat API and therefore improve the extensibility of the framework.
• Fix tsconfig

Reviewers should focus on:

Screenshot

QA

1. Try to extend/override a newly added component from core
2. Try to extend/override a newly added component from an extension
3. Try to use a newly added util which is the default export (i.e. fireDebugWarning)
4. Try to use a newly added util which is a non default export (i.e. fireDeprecationWarning)

Necessity

• Has the problem that is being solved here been clearly explained?
• If applicable, have various options for solving this problem been considered?
• For core PRs, does this need to be in core, or could it be in an extension?
• Are we willing to maintain this for years / potentially forever?

Confirmed

• Frontend changes: tested on a local Flarum installation.
• Backend changes: tests are green (run composer test).
• Core developer confirmed locally this works as intended.
• Tests have been added, or are not appropriate here.

Required changes:

• Related documentation PR: (Remove if irrelevant)
• Related core extension PRs: (Remove if irrelevant)

[SychO9]

@DavideIadeluca for 2.x you don't actually need to do anything 👍

In 2.x every module used by the code (core and extensions) is accessible by other extensions. Unless the module is declared but not used (which is not the case currently).

[DavideIadeluca]

@DavideIadeluca for 2.x you don't actually need to do anything 👍

In 2.x every module used by the code (core and extensions) is accessible by other extensions. Unless the module is declared but not used (which is not the case currently).

@SychO9 Yeah I was also of the same understanding per the diary you shared on discuss. But I'm kind of confused now what the usage is for the newly added forum.ts files in core and extensions?

framework/framework/core/js/src/forum/forum.ts

Lines 1 to 53 in da441c7

	import '../common/common';
	import '../common/utils/BasicEditorDriver';
	import './utils/PostControls';
	import './utils/slidable';
	import './utils/History';
	import './utils/DiscussionControls';
	import './utils/UserControls';
	import './utils/Pane';
	import './states/ComposerState';
	import './states/DiscussionListState';
	import './states/GlobalSearchState';
	import './states/NotificationListState';
	import './states/PostStreamState';
	import './components/AffixedSidebar';
	import './components/DiscussionPage';
	import './components/DiscussionListPane';
	import './components/Notification';
	import './components/LogInButton';
	import './components/SessionDropdown';
	import './components/HeaderPrimary';
	import './components/PostEdited';
	import './components/IndexPage';
	import './components/DiscussionRenamedNotification';
	import './components/DiscussionsSearchSource';
	import './components/HeaderSecondary';
	import './components/DiscussionList';
	import './components/AvatarEditor';
	import './components/Post';
	import './components/LoadingPost';
	import './components/TerminalPost';
	import './components/NotificationsDropdown';
	import './components/UserPage';
	import './components/PostUser';
	import './components/UserCard';
	import './components/UsersSearchSource';
	import './components/PostPreview';
	import './components/EventPost';
	import './components/DiscussionHero';
	import './components/PostMeta';
	import './components/DiscussionRenamedPost';
	import './components/LogInButtons';
	import './components/NotificationList';
	import './components/WelcomeHero';
	import './components/CommentPost';
	import './components/ComposerPostPreview';
	import './components/RenameDiscussionModal';
	import './components/Search';
	import './components/DiscussionListItem';
	import './components/PostsUserPage';
	import './resolvers/DiscussionPageResolver';
	import './routes';
	import './ForumApplication';

framework/extensions/flags/js/src/forum/forum.ts

Lines 1 to 10 in da441c7

	import './addFlagsToPosts';
	import './addFlagControl';
	import './addFlagsDropdown';
	import './models/Flag';
	import './components/FlagList';
	import './components/FlagPostModal';
	import './components/FlagsPage';
	import './components/FlagsDropdown';

[SychO9]

@DavideIadeluca those are mostly the result of automatically converting the old compat files. A lot of the imports there are redundant and add nothing. However because we now lazy load certain components, those files serve as a way to ensure certain components are not lazy loaded, without having to constantly check where they are used.

We'll probably remove those (forum.ts, common.ts, admin.ts) files for the bundled extensions before 2.0 is out.