Disallow indefinite http client timeout #210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Ensure that timeout for relay requests to be greater than 0.
⛱ Motivation and Context
0 and negative timeout values result in no timeout, which a malicious relay can potentially block execution, especially in the
handleGetHeader
function.📚 References
✅ I have run these commands
make lint
make test
make run-mergemock-integration
go mod tidy