Handle noTxPool correctly #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmel
commented
Aug 14, 2024
jinmel
commented
- noTxPool is handled by the caller, of which there are two: CLSync and Driver.
- noTxPool should be handled in case when there is a specific request from sequencer where there needs to be a upgrade tx that sets noTxPool to perform chain upgrade.
- noTxPool is handled by the caller, of which there are two: CLSync and Driver. - noTxPool should be handled in case when there is a specific request from sequencer where there needs to be a upgrade tx that sets noTxPool to perform chain upgrade.
avalonche
reviewed
Aug 14, 2024
op-node/rollup/clsync/clsync.go
Outdated
| attrs.NoTxPool = uint64(attrs.Timestamp) > l1Origin.Time+eq.spec.MaxSequencerDrift(l1Origin.Time) | ||
|
|
||
| // For the Ecotone activation block we shouldn't include any sequencer transactions. | ||
| if eq.cfg.IsEcotoneActivationBlock(uint64(attrs.Timestamp)) { |
There was a problem hiding this comment.
so do we not add transactions for the activation block of every fork?
There was a problem hiding this comment.
yes it seems so. here is where this snippet comes from.
avalonche
reviewed
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.