Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: builder session manager env var config #19

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feature: builder session manager env var config #19

wants to merge 16 commits into from

Conversation

allnil
Copy link

@allnil allnil commented Feb 24, 2024

draft, work on envs

@allnil allnil changed the title feature: add env config to see diffs feature: builder session manager env var config Feb 24, 2024
@allnil
Copy link
Author

allnil commented Feb 24, 2024

hi ferranbt !
I moved PR and got rid of Viper!
Maybe you could share some nits on how to make it better
thanks :)

@allnil allnil marked this pull request as ready for review February 24, 2024 18:11
ferranbt
ferranbt reviewed Feb 26, 2024
View reviewed changes
eth/backend.go Outdated Show resolved Hide resolved
@allnil allnil requested a review from ferranbt February 26, 2024 14:49
@allnil allnil requested review from metachris and ferranbt March 1, 2024 09:02
@allnil
Copy link
Author

allnil commented Mar 5, 2024 •
edited
Loading

hmmm
@ferranbt
There are some issues with example tests
I tried to run them from the main branch and got the same error as in ci log

_2024/03/02 15:58:21 Test address 1: 0x99A24Fe271a0f754fD55A48Cb3b2bC84f16875f7
panic: Post "http://localhost:8555": read tcp [::1]:36920->[::1]:8555: read: connection reset by peer

goroutine 1 [running]:
main.maybe(...)
	/home/runner/work/suave-execution-geth/suave-execution-geth/suapp-examples/examples/build-eth-block/main.go:87
main.main()
	/home/runner/work/suave-execution-geth/suave-execution-geth/suapp-examples/examples/build-eth-block/main.go:24 +0x[91](https://github.com/flashbots/suave-execution-geth/actions/runs/8101826092/job/22204681002?pr=19#step:8:92)1
exit status 2_
make: *** [Makefile:31: run-integration] Error 1

@allnil allnil mentioned this pull request Mar 7, 2024
Merged
Merge branch 'fix/fix-devenv-docker-compose' of github.com:allnil/go-…
ef9b18e 
…ethereum into feature/max-builder-session-env-config
@allnil allnil requested a review from ferranbt March 7, 2024 18:45
@allnil allnil mentioned this pull request Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruteri Ruteri Awaiting requested review from Ruteri Ruteri is a code owner

@dmarzzz dmarzzz Awaiting requested review from dmarzzz dmarzzz is a code owner

@lthibault lthibault Awaiting requested review from lthibault

@metachris metachris Awaiting requested review from metachris metachris is a code owner

@ferranbt ferranbt Awaiting requested review from ferranbt ferranbt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allnil @metachris @ferranbt