adds AddTransactions, AddBundle, AddBundles to the builder API #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmel
requested review from
ferranbt,
Ruteri,
metachris,
dmarzzz and
lthibault
as code owners
ferranbt
requested changes
Mar 13, 2024
suave/builder/session_manager.go
Outdated
| return builder.AddTransactions(txs) | ||
| } | ||
|
|
||
| func (s *SessionManager) AddBundle(sessionId string, bundle *api.Bundle) (*api.SimulateBundleResult, error) { |
There was a problem hiding this comment.
Can we merge AddBundle with AddBundles? That way we can reduce the scope of the API.
There was a problem hiding this comment.
Note that we cannot do the same with AddTransactions because of the backward compatibility.
| @@ -39,8 +39,16 @@ func (nullSessionManager) AddTransaction(sessionId string, tx *types.Transaction | |||
| return &SimulateTransactionResult{Logs: []*SimulatedLog{}}, nil | |||
| } | |||
|
|
|||
| func (nullSessionManager) AddBundle(sessionId string, bundle Bundle) error { | |||
| return nil | |||
| func (nullSessionManager) AddTransactions(sessionId string, txs types.Transactions) ([]*SimulateTransactionResult, error) { | |||
There was a problem hiding this comment.
Can you call these functions in TestAPI test? It is to make sure that both server and client encode the same thing.
ferranbt
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.