line_parser.go:158: cannot parse docker message, invalid JSON: #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//127.0.0.1:10250/pods, status code: 200, body len: 153223
…valid character when use containerd CRI
kongfei605
reviewed
Jul 11, 2024
| @@ -134,7 +134,9 @@ func (kc *kubeletClient) query(ctx context.Context, path string) ([]byte, int, e | |||
| return nil, 0, err | |||
| } | |||
|
|
|||
| log.Printf("Successfully queried %s, status code: %d, body len: %d", req.URL.String(), response.StatusCode, len(b)) | |||
| if coreconfig.Config.DebugMode { | |||
There was a problem hiding this comment.
有个单独针对logs-agent的debug 判断 util.Debug()
kongfei605
reviewed
Jul 11, 2024
logs/input/kubernetes/launcher.go
Outdated
| @@ -200,6 +200,10 @@ func (l *Launcher) addSource(svc *service.Service) { | |||
| // force setting source type to kubernetes | |||
| source.SetSourceType(logsconfig.KubernetesSourceType) | |||
|
|
|||
| // Determine whether CRI uses containerd | |||
| if pod.Status.Containers[0].ID[:13] == "containerd://" { | |||
There was a problem hiding this comment.
不好意思。 第一次写golang, 不是很熟悉。也修改了。这样应该不会panic了。
|
Thank you @2005wind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 在containerd日志格式下，错误日志匹配。以及query 日志太多