chore: Add rate limiting log #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongfei605
reviewed
Aug 30, 2024
logs/sender/batch_strategy.go
Outdated
| @@ -108,6 +108,10 @@ func (s *batchStrategy) processMessage(m *message.Message, outputChan chan *mess | |||
| } | |||
| added := s.buffer.AddMessage(m) | |||
| if !added || s.buffer.IsFull() { | |||
| if s.buffer.IsFull() { | |||
| log.Printf("I! buffer full len: %s, size: %s", | |||
kongfei605
changed the title
|
Thank you @luoyuLianga |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加触发限流的标识
如果缓存允许最大并发批次是1k，如下
但是实际处理过程中，如果有发现超过1k的并发，那么应该有标识，标识输出的内容是：“buffer full”
同时可以配合mtail发现关键字，进一步针对指标配置阈值、告警，一气呵成
需要注意的一点是：
如果采集的内容达到一次发送的上限，也会直接发送走，不会触发该标识。所以需要合理定义batch_max_size、batch_max_content_size大小