Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netpref license gets the wrong license from upstream #1459

Closed
miao0miao opened this issue May 29, 2024 · 7 comments · Fixed by flatcar/scripts#2027
Closed

netpref license gets the wrong license from upstream #1459

miao0miao opened this issue May 29, 2024 · 7 comments · Fixed by flatcar/scripts#2027
Labels
area/CNCF kind/bug Something isn't working

Comments

@miao0miao
Copy link
Contributor

miao0miao commented May 29, 2024

Description

netperf gets the license from upstream.
The license is pulled from http://www.netperf.org/ - the website is down.
It moved to Github https://github.com/HewlettPackard/netperf and uses the MIT license

@miao0miao miao0miao added the kind/bug Something isn't working label May 29, 2024
ader1990 added a commit to flatcar/scripts that referenced this issue May 29, 2024
Use License from the github repo:
https://github.com/HewlettPackard/netperf/blob/master/COPYING

Fixes: flatcar/Flatcar#1459

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to ader1990/gentoo that referenced this issue May 30, 2024
Use the latest License from the netperf GitHub repo:
https://github.com/HewlettPackard/netperf/blob/master/COPYING

See: flatcar/Flatcar#1459

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to ader1990/gentoo that referenced this issue May 30, 2024
Use the latest License from the netperf GitHub repo:
https://github.com/HewlettPackard/netperf/blob/master/COPYING

See: flatcar/Flatcar#1459

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
@ader1990
Copy link

The License is still correct, as the Gentoo upstream and Flatcar still use the 2.7.0 tar.gz sources. See: https://github.com/flatcar/scripts/blob/main/sdk_container/src/third_party/portage-stable/net-analyzer/netperf/netperf-2.7.0-r3.ebuild#L9C10-L9C31

@t-lo
Copy link
Member

t-lo commented May 31, 2024

I think we should update to the one that switched to the MIT license; the one we're shipping cannot be used for commercial purposes. Either we update or we switch to something more modern (and better maintained) entirely, e.g. fio.

@ader1990
Copy link

I think we should update to the one that switched to the MIT license; the one we're shipping cannot be used for commercial purposes. Either we update or we switch to something more modern (and better maintained) entirely, e.g. fio.

We could fork the repo under the Flatcar umbrella, create a tag and a release on Github so that the sources can be retrieved and then move it from portage stable to overlay?

@ader1990
Copy link

The best way would be though to +1 this issue HewlettPackard/netperf#75?

@jepio
Copy link
Member

jepio commented May 31, 2024

I pushed a PR that can be used as a reference showing how to package a fixed commit of netperf: flatcar/scripts#2015

Please feel free to take over, I don't really have the time to follow up on this.

@jepio
Copy link
Member

jepio commented May 31, 2024

Thilo found that netperf is part of production images, but only the devcontainer. It's better to drop.

@t-lo
Copy link
Member

t-lo commented Jun 12, 2024

Gentoo upstream is now shipping an ebuild of the latest github state: https://github.com/gentoo/gentoo/blob/6f42017f1c4cb1ff42618a097f87fceffbdf1ad3/net-analyzer/netperf/netperf-2.7.0_p20210121.ebuild#L10

It's unstable (masked), but we could import that and unmask it for Flatcar. Ships with MIT license.

ader1990 added a commit to flatcar/scripts that referenced this issue Jun 12, 2024
Fixes: flatcar/Flatcar#1459

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990 added a commit to flatcar/scripts that referenced this issue Jun 12, 2024
As the net-analyzer/netperf stable version does not have a clear
License, the upstream Gentoo package has a masked ebuild that uses the
source from Github commit:
HewlettPackard/netperf@3bc455b

This change unmasks netperf-2.7.0_p20210121 for amd64 and arm64.

Also, added netperf to the github actions sync list.

Fixes: flatcar/Flatcar#1459

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
@github-project-automation github-project-automation bot moved this from 📝 Needs Triage to Implemented in Flatcar tactical, release planning, and roadmap Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CNCF kind/bug Something isn't working
Projects
4 participants