-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(openstack): add OVHcloud example #27
chore(openstack): add OVHcloud example #27
Conversation
Thanks a lot for this PR I was not expecting this that fast! I think it's better to have the examples in it's own |
acfea89
to
2f0d39c
Compare
@tormath1 Just pushed the OVHcloud version, largely copied from Openstack but with some modifications (notably on the image). |
Thanks a lot - I am on vacation from tonight and for a few weeks, I'll have a look at my return (or if someone from @flatcar/flatcar-maintainers wants to review it) |
user_name = var.user_name | ||
tenant_name = var.tenant_name | ||
password = var.password | ||
auth_url = var.auth_url | ||
region = var.region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just add a note to the OVH documentation to find those information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some links to documentation but did not find a lot of useful things on OVHcloud :|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! Just one question and it's good to go.
2f0d39c
to
cf72546
Compare
@spnngl thanks a lot for providing those examples. I am sure they will be helpful for folks that want to run Flatcar on OVH. |
[OVHcloud openstack image example]
Add flatcar image import example for OVHcloud.
How to use
Try using this image on OVHcloud, we have used this for years now.
Closes: flatcar/Flatcar#1453