Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tutorial section for improved clarity and structure #368

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

John15321
Copy link
Contributor

@John15321 John15321 commented Oct 31, 2024

Refactor the Tutorial section for Improved clarity and structure by re-formatting certain sections and re-arranging the flow of links to references.

Testing done

Built and ran the docs locally.

@tormath1 tormath1 requested a review from a team October 31, 2024 11:31
Copy link
Collaborator

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the clean-up. Most of the comments are for things you did not touch but while at here... :)

content/docs/latest/tutorial/hands-on-2/_index.md Outdated Show resolved Hide resolved
content/docs/latest/tutorial/hands-on-4/_index.md Outdated Show resolved Hide resolved
content/docs/latest/tutorial/hands-on-4/_index.md Outdated Show resolved Hide resolved
chewi
chewi previously approved these changes Oct 31, 2024
Copy link
Contributor

@chewi chewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer, thank you.

Side note: Should we start pointing at OpenTofu rather than Terraform now?

@John15321
Copy link
Contributor Author

Looks good. Thanks for the clean-up. Most of the comments are for things you did not touch but while at here... :)

Done! 🙂

@John15321
Copy link
Contributor Author

@chewi @tormath1 Do you guys have any ideas why the pipeline is failing? I am not familiar with this CI, but judging from the error it may be due to my account not having some kind of a token associated with it?:

The deployment_token is required for deploying content. If you'd like to continue the run without deployment, add the configuration skip_deploy_on_missing_secrets set to true in your workflow file

@tormath1
Copy link
Collaborator

@chewi @tormath1 Do you guys have any ideas why the pipeline is failing? I am not familiar with this CI, but judging from the error it may be due to my account not having some kind of a token associated with it?:

The deployment_token is required for deploying content. If you'd like to continue the run without deployment, add the configuration skip_deploy_on_missing_secrets set to true in your workflow file

IIRC it's because this is not available when executed from a fork:

azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_LEMON_WAVE_085522403 }}

So the Azure deployment (for preview) is failing.

Copy link
Collaborator

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Feel free to squash your commits - it's up to you for the OpenTofu suggestion, I don't have a strong opinion on this. You can do it now, or in a follow-up PR if you feel it requires it.

@John15321
Copy link
Contributor Author

Thanks! Honestly I dont know much about OpenTofu . So for now I would leave it

@tormath1 tormath1 merged commit 0b87f2e into flatcar:master Oct 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants