-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Tutorial section for improved clarity and structure #368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the clean-up. Most of the comments are for things you did not touch but while at here... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer, thank you.
Side note: Should we start pointing at OpenTofu rather than Terraform now?
Done! 🙂 |
@chewi @tormath1 Do you guys have any ideas why the pipeline is failing? I am not familiar with this CI, but judging from the error it may be due to my account not having some kind of a token associated with it?:
|
IIRC it's because this is not available when executed from a fork:
So the Azure deployment (for preview) is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! Feel free to squash your commits - it's up to you for the OpenTofu suggestion, I don't have a strong opinion on this. You can do it now, or in a follow-up PR if you feel it requires it.
Thanks! Honestly I dont know much about OpenTofu . So for now I would leave it |
Refactor the Tutorial section for Improved clarity and structure by re-formatting certain sections and re-arranging the flow of links to references.
Testing done
Built and ran the docs locally.