kola/tests: Drop obsolete cl.update.grubnop test #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code to binary patch GRUB was dropped from update_engine some time ago in flatcar/update_engine@e688113, so it no longer makes sense to test this. I would have also needed to update the test to handle xz compression now that we are switching to that. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
tormath1
approved these changes
Nov 18, 2024
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop obsolete cl.update.grubnop kola test
The code to binary patch GRUB was dropped from update_engine some time ago in flatcar/update_engine@e688113, so it no longer makes sense to test this.
I would have also needed to update the test to handle xz compression now that we are switching to that.
How to use
Nothing to use, simply dropping a test.
Testing done
Nothing to test.