Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run partprobe after Ignition partition changes #1202

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

pothos
Copy link
Member

@pothos pothos commented Sep 29, 2023

This adds coreos/ignition#1717 as downstream
patch to fix flatcar/Flatcar#1194

How to use

Backport to Stable after some time?

Testing done

In Jenkins and manually with:

variant: flatcar
version: 1.0.0
storage:
  disks:
  - device: /dev/vda
    partitions:
    - label: VAR
      number: 10
      size_mib: 1
  filesystems:
  - device: /dev/disk/by-partlabel/VAR
    format: vfat
    path: /var
    label: var
    with_mount_unit: true
  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@pothos pothos temporarily deployed to development September 29, 2023 16:16 — with GitHub Actions Inactive
@pothos pothos temporarily deployed to development October 1, 2023 14:15 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Build action triggered: https://github.com/flatcar/scripts/actions/runs/6381754978

@pothos pothos temporarily deployed to development October 2, 2023 10:00 — with GitHub Actions Inactive
@pothos pothos temporarily deployed to development October 2, 2023 13:49 — with GitHub Actions Inactive
@pothos pothos changed the title wip: Run partprobe after Ignition partition changes Run partprobe after Ignition partition changes Oct 2, 2023
@pothos pothos marked this pull request as ready for review October 2, 2023 13:52
@pothos pothos requested a review from a team October 2, 2023 13:52
@pothos
Copy link
Member Author

pothos commented Oct 2, 2023

cl.disk.raid0.root and cl.disk.raid1.root failed initially but this is fixed (forgot to add partprobe to the initrd) and passes in Jenkins, the GitHub Actions have to catch up.

@pothos
Copy link
Member Author

pothos commented Oct 2, 2023

I think I'll backport it to Beta which will be the next Stable.

@pothos pothos merged commit c3a7928 into main Oct 2, 2023
@pothos pothos deleted the kai/partprobe branch October 2, 2023 14:36
pothos added a commit that referenced this pull request Oct 2, 2023
Run partprobe after Ignition partition changes
@pothos
Copy link
Member Author

pothos commented Oct 2, 2023

Backported down to flatcar-3602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in udev handling when partitions are created by ignition
3 participants