Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroupv1: abort the update if Flatcar version does not support it #41

Draft
wants to merge 1 commit into
base: flatcar-master
Choose a base branch
from

Conversation

ader1990
Copy link

cgroupv1: abort the update if Flatcar version does not support it

See: flatcar/scripts#2145

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@ader1990 ader1990 force-pushed the ader1990/cgroupv1-no-upgrade branch 2 times, most recently from d13ccd0 to e0fb3ab Compare October 24, 2024 14:26
flatcar-postinst Outdated Show resolved Hide resolved
flatcar-postinst Outdated Show resolved Hide resolved
flatcar-postinst Outdated
# Systemd version >= 256 does not boot anymore if cgroupv1 is enabled or SYSTEMD_CGROUP_ENABLE_LEGACY_FORCE=1 is set
# See: https://github.com/systemd/systemd/releases/tag/v256-rc3
MAX_NEXT_VERSION_ID=5000
if [ "${NEXT_VERSION_ID%%.*}" -ge $MAX_NEXT_VERSION_ID && ! -f "/sys/fs/cgroup/cgroup.controllers" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we don't need a version check here. We can ensure that any Flatcar version that has an update-engine that contains this change is merged together with the systemd-256 update.

am i wrong about this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the check, but left the version number that will be changed accordingly so the user gets the release information.

@ader1990 ader1990 force-pushed the ader1990/cgroupv1-no-upgrade branch from e0fb3ab to 626d4b7 Compare October 24, 2024 14:34
@ader1990 ader1990 force-pushed the ader1990/cgroupv1-no-upgrade branch from 626d4b7 to df41db0 Compare October 24, 2024 14:37
@ader1990 ader1990 self-assigned this Oct 24, 2024
@ader1990 ader1990 marked this pull request as draft October 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants