Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'torrent' and other keywords to .desktop file #10

Merged
merged 1 commit into from
Apr 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions 0003-Remove-X-GNOME-FullName-from-the-.desktop-file.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
From 5cefddeaeea8f75d12e2b04d37e9302803008af3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20Dr=C4=85g?= <piotrdrag@gmail.com>
Date: Sat, 28 Jan 2017 23:52:32 +0100
Subject: [PATCH 1/2] Remove X-GNOME-FullName from the .desktop file

It's a GNOME-specific hack for the 2.x era menu system that was never
standardized in [1] and is now unused in GNOME 3.

[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
---
gtk/transmission-gtk.desktop.in | 1 -
1 file changed, 1 deletion(-)

diff --git a/gtk/transmission-gtk.desktop.in b/gtk/transmission-gtk.desktop.in
index 51ee8b771..2b6e799b8 100644
--- a/gtk/transmission-gtk.desktop.in
+++ b/gtk/transmission-gtk.desktop.in
@@ -1,7 +1,6 @@
[Desktop Entry]
_Name=Transmission
_GenericName=BitTorrent Client
-_X-GNOME-FullName=Transmission BitTorrent Client
_Comment=Download and share files over BitTorrent
Exec=transmission-gtk %U
Icon=transmission
--
2.14.3

32 changes: 32 additions & 0 deletions 0004-Add-Keywords-to-the-.desktop-file.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
From 297c734c0b97e26e2c3b4322f9ce9947b08fb3a7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20Dr=C4=85g?= <piotrdrag@gmail.com>
Date: Sat, 28 Jan 2017 23:57:01 +0100
Subject: [PATCH 2/2] Add Keywords to the .desktop file

It's a part of the Desktop Entry Specification [1] and it's used by,
among others, the search system in GNOME 3.

The comment is there to hopefully minimize the chance of translators
making a mistake that could potentially break build.

[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
---
gtk/transmission-gtk.desktop.in | 2 ++
1 file changed, 2 insertions(+)

diff --git a/gtk/transmission-gtk.desktop.in b/gtk/transmission-gtk.desktop.in
index 2b6e799b8..3e606264f 100644
--- a/gtk/transmission-gtk.desktop.in
+++ b/gtk/transmission-gtk.desktop.in
@@ -2,6 +2,8 @@
_Name=Transmission
_GenericName=BitTorrent Client
_Comment=Download and share files over BitTorrent
+# Translators: Search terms to find this application. Do NOT translate or localize the semicolons! The list MUST also end with a semicolon!
+_Keywords=torrents;downloading;uploading;share;sharing;
Exec=transmission-gtk %U
Icon=transmission
Terminal=false
--
2.14.3

5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This manifest allows Transmission access to:

* the network, for obvious reasons
* X11 and Wayland, also for obvious reasons
* the host filesystem, because Transmission hasn't been adapted to use [portals](https://github.com/flatpak/flatpak/wiki/Portals) to open `.torrents` and read/write downloads
* the host filesystem, because Transmission hasn't been adapted to use [portals](https://github.com/flatpak/flatpak/wiki/Portals) to open `.torrent`s and read/write downloads
* PulseAudio, to play a "ding!" when a transfer is complete
* Notifications, to show a bubble when a transfer is complete
* DConf, because Gtk's file chooser tries to save its position, visible columns, etc.
Expand All @@ -17,7 +17,8 @@ This manifest allows Transmission access to:

* `com.transmissionbt.Transmission.appdata.xml`: [accepted upstream](https://github.com/transmission/transmission/pull/224) but not yet part of a release.
* `0001-gtk-use-com.transmissionbt.Transmission.-D-Bus-names.patch`: Flatpak only allows apps to own names within the namespace matching the app name. Not submitted upstream.
* `gtk-add-symbolic-icon.patch`: [submitted upstream](https://github.com/transmission/transmission/pull/449).
* `0002-gtk-add-symbolic-icon.patch`: [submitted upstream](https://github.com/transmission/transmission/pull/449).
* `0003-Remove-X-GNOME-FullName-from-the-.desktop-file.patch`, `0004-Add-Keywords-to-the-.desktop-file.patch`: [backported from upstream](https://github.com/transmission/transmission/pull/162).

## Colophon

Expand Down
8 changes: 8 additions & 0 deletions com.transmissionbt.Transmission.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@
"type": "patch",
"path": "0002-gtk-add-symbolic-icon.patch"
},
{
"type": "patch",
"path": "0003-Remove-X-GNOME-FullName-from-the-.desktop-file.patch"
},
{
"type": "patch",
"path": "0004-Add-Keywords-to-the-.desktop-file.patch"
},
{
"type": "shell",
"commands": [
Expand Down