Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-checker-data for all modules & Remove zlib #23

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

guihkx
Copy link
Contributor

@guihkx guihkx commented Jun 9, 2023

This adds support for Flathub's external data checking tool, to help maintainers keep all modules up-to-date. In the process, I've updated xrandr from 1.5.1 to 1.5.2.

In addition, I've updated the checking source for Prism itself, which was previously using Anitya but now checks for GitHub Releases directly, which is faster.

And finally, I've also removed the zlib module (introduced because of #15), since the 22.08 version of the Freedesktop runtime is now using the latest, current version of it (v1.2.13):

https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/commit/4fc255e155ef8d2f5a1ec593784b61527c1d829f


Miscellaneous changes (not worthy of their own, separate commit, IMO):

  • Remove some leftover files created by some modules (C headers, static libraries, pkg-config files, manpages)

  • Separate each module by a new, empty line (this is REALLY important)

  • Replace inline YAML arrays (e.g. [foo, bar, baz]) by lists (also very important):

    - foo
    - bar
    - baz

guihkx added 4 commits June 9, 2023 03:15
The previous source was Anitya, which doesn't make much sense, since we
can query the GitHub repository directly for new versions instead.
And also:

- Switch from the git source to the tarball one
- Remove unused files: C header, pkg-config file, static library
This module was first added because version 22.08.9 of the Freedesktop
runtime was using a problematic version of zlib (see issue flathub#15).

However, since then, zlib has been updated to v1.2.13 in the 22.08.10
version of the runtime:

https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/commit/4fc255e155ef8d2f5a1ec593784b61527c1d829f

Therefore, we can remove it from here.
@flathubbot
Copy link
Contributor

Started test build 46205

@flathubbot
Copy link
Contributor

Build 46205 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28826/org.prismlauncher.PrismLauncher.flatpakref

Copy link
Collaborator

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Scrumplex Scrumplex merged commit 0fce6b7 into flathub:master Jun 16, 2023
@guihkx guihkx deleted the data-checker-n-cleanups branch June 16, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants