Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSHint errors. Enable strict mode. #278

Merged
merged 1 commit into from
Jan 18, 2016
Merged

Fix JSHint errors. Enable strict mode. #278

merged 1 commit into from
Jan 18, 2016

Conversation

panuhorsmalahti
Copy link
Contributor

Fix most JSHint errors in lib/cradle/database/attachments.js and lib/cradle/database/changes.js. Added a FIXME comment about use of non-declared 'cached' parameter.

@indexzero
Copy link
Member

What .jshintrc are you using? If we're going to make lint changes please use my styleguide: https://github.com/indexzero/styleguide.

@panuhorsmalahti
Copy link
Contributor Author

I used the default settings of JSHint, which is the "golden standard" of linting. I'll have to take a look later on how the styleguide you linked differs from the default rules. If the .jshintrc differs from the default settings I think the file should be added to cradle's repository.

@indexzero
Copy link
Member

@panuhorsmalahti the styleguide itself is the lint files. It's so I don't have to maintain 100 different lint files in 100 different projects. See how I used it in http-server: http-party/http-server@9fbfae5#diff-1

@indexzero
Copy link
Member

That is just add the following to the package.json:

{
  // other values
  "scripts": {
    "pretest": "stylezero lib/ test/"
  },
  // more others values
  "devDependencies": {
    "stylezero": "2.1.1"
  }
}

panuhorsmalahti added a commit that referenced this pull request Jan 18, 2016
Fix JSHint errors. Enable strict mode.
@panuhorsmalahti panuhorsmalahti merged commit e0526dd into flatiron:master Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants